Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemeshard: fix Alter{Ext,}SubDomain compatibility #9198

Merged
merged 1 commit into from
Sep 13, 2024
Merged

schemeshard: fix Alter{Ext,}SubDomain compatibility #9198

merged 1 commit into from
Sep 13, 2024

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Sep 13, 2024 •
edited
Loading

TAlterExtSubDomain suboperation should be able accept ESchemeOpAlterSubDomain operation type.
(Notice ExtSubDomain vs SubDomain.)

This is special compatibility case for those old subdomains that went through migration to a separate tenants at some time. Console tablet holds records about types of the subdomains but they hadn't been updated at the time of migration. So Console still thinks that old subdomains are plain subdomains whereas they had been migrated to the extsubdomains. And Console tablet is the main source of the subdomains alters. This compatibility case should be upholded until Console records will be fixed.

KIKIMR-21965

Changelog category

  • Not for changelog

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@ijon
schemeshard: fix AlterExtSubDomain compatibility with ESchemeOpAlterS…
a132105 
…ubDomain

TAlterExtSubDomain suboperation should be able accept ESchemeOpAlterSubDomain
operation type.

This is special compatibility case for those old subdomains that
went through migration to a separate tenants at some time.
Console tablet holds records about types of the subdomains but they hadn't been
updated at the time of migration. So Console still thinks that old subdomains
are plain subdomains whereas they had been migrated to the extsubdomains.
And Console tablet is the main source of the subdomains alters.
This compatibility case should be upholded until Console records will be fixed.

KIKIMR-21965
@ijon ijon force-pushed the fix-schemeshard-alter-compatibility branch from 16baa5a to a132105 Compare September 13, 2024 09:01
@ijon ijon requested a review from snaury September 13, 2024 09:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

⚪ 2024-09-13 09:05:23 UTC Pre-commit check linux-x86_64-release-clang14 for 7a06fac has started.
⚪ 2024-09-13 09:05:33 UTC Artifacts will be uploaded here
⚪ 2024-09-13 09:08:20 UTC ya make is running...
🟢 2024-09-13 09:14:02 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

⚪ 2024-09-13 09:06:41 UTC Pre-commit check linux-x86_64-release-asan for 7a06fac has started.
⚪ 2024-09-13 09:07:15 UTC Artifacts will be uploaded here
⚪ 2024-09-13 09:10:35 UTC ya make is running...
🔴 2024-09-13 10:46:24 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10388 10235 0 23 34 96

🟢 2024-09-13 10:47:19 UTC Build successful.
🟡 2024-09-13 10:47:49 UTC ydbd size 5.6 GiB changed* by +137.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a3a6517 merge: 7a06fac diff diff %
ydbd size 6 051 723 584 Bytes 6 051 864 104 Bytes +137.2 KiB +0.002%
ydbd stripped size 1 514 603 760 Bytes 1 514 632 112 Bytes +27.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

⚪ 2024-09-13 09:07:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7a06fac has started.
⚪ 2024-09-13 09:07:31 UTC Artifacts will be uploaded here
⚪ 2024-09-13 09:10:19 UTC ya make is running...
🟡 2024-09-13 10:09:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15010 13538 0 4 1373 95

⚪ 2024-09-13 10:10:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-13 10:21:11 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 15 0 0 0 85

🟢 2024-09-13 10:21:18 UTC Build successful.
🟢 2024-09-13 10:21:56 UTC ydbd size 8.4 GiB changed* by +92.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a3a6517 merge: 7a06fac diff diff %
ydbd size 9 041 957 648 Bytes 9 042 052 168 Bytes +92.3 KiB +0.001%
ydbd stripped size 488 846 248 Bytes 488 846 248 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

This was referenced Sep 13, 2024
Merged
Merged
@ijon ijon linked an issue Sep 13, 2024 that may be closed by this pull request
schemeshard crash on concurrent alter-{ext,}subdomains #9204
Closed
@ijon ijon merged commit b0a5850 into ydb-platform:main Sep 13, 2024
10 of 12 checks passed
@ijon ijon deleted the fix-schemeshard-alter-compatibility branch September 13, 2024 11:00
ijon added a commit that referenced this pull request Sep 13, 2024
@ijon
24-3-9-hotfix: schemeshard: fix crash on concurrent alter-extsubdomai…
bce4f3a 
…ns (#9203)

merge 5c36245(#9157), ...(#9198) from `main`

KIKIMR-21965

- enforce creation of `TAlterExtSubDomain` operations only through `CreateCompatibleAlterExtSubDomain()` to ensure all proper state checking
- fix `TAlterExtSubDomain` compatibility with ESchemeOpAlterSubDomain
ijon added a commit that referenced this pull request Sep 13, 2024
@ijon
24-3: schemeshard: fix crash on concurrent alter-extsubdomains (#9201)
1b9a283 
merge 5c36245(#9157), ...(#9198) from `main`

KIKIMR-21965

- enforce creation of `TAlterExtSubDomain` operations only through `CreateCompatibleAlterExtSubDomain()` to ensure all proper state checking
- fix `TAlterExtSubDomain` compatibility with ESchemeOpAlterSubDomain
This was referenced Sep 13, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
This was referenced Sep 18, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaury snaury snaury approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schemeshard crash on concurrent alter-{ext,}subdomains
2 participants
@ijon @snaury